http://codereview.chromium.org/100160/diff/1/2 File SConstruct (right):
http://codereview.chromium.org/100160/diff/1/2#newcode158 Line 158: 'CPPDEFINES': ['V8_ARCH_X64', 'LP64'] Shouldn't you rely on __LP64__ being defined by the compiler? Also as a note of warning Windows 64-bit uses (LL)P64, so while we are bringing this up we should take care to not use long to mean 64-bit values, but use a sized type such as int64_t. Actually thinking about this second point, I think it illustrates well that you should not define LP64 here because it will be wrong on certain architectures. Same for ILP32, I don't think it should be defined in the build files. http://codereview.chromium.org/100160/diff/1/2#newcode213 Line 213: 'CPPDEFINES': ['ARM'] This is now redundant and should be removed. As are the other defintions of ARM. http://codereview.chromium.org/100160/diff/1/2#newcode612 Line 612: Abort("X64 compilation only allowed on Linux OS.") Why? The Mac has a perfectly fine working x64 environment. And it would be nice to be able to test on a secondary platform occasionally. http://codereview.chromium.org/100160 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
