http://codereview.chromium.org/100160/diff/1/2 File SConstruct (right):
http://codereview.chromium.org/100160/diff/1/2#newcode158 Line 158: 'CPPDEFINES': ['V8_ARCH_X64', 'LP64'] Personally, I prefer setting everything myself to depending on the compiler. It is exactly because of Windows using LLPC64 that we are going to need to differentiate, and I much prefer being in control to relying on some property that might differ between compilers. If not all GCC compilers use LP64 as 64-bit data model, then these declarations should be fixed. The ones I am aware of should do so. The setting for the MSVC compiler should be in another sub-section (and hasn't been added yet). I.e., it was deliberate, but I'm open to arguments for other approaches. http://codereview.chromium.org/100160/diff/1/2#newcode213 Line 213: 'CPPDEFINES': ['ARM'] Done. http://codereview.chromium.org/100160/diff/1/2#newcode612 Line 612: Abort("X64 compilation only allowed on Linux OS.") Yes, there is probably no reason for this restriction anyway. We don't guarantee that it compiles anyway, yet. I didn't remove it before committing, but it should be removed when there's an occasion. http://codereview.chromium.org/100160 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
