We need to add tests for this. There are uncovered paths in this code and there seems to be bugs.
http://codereview.chromium.org/99272/diff/1/2 File src/array.js (right): http://codereview.chromium.org/99272/diff/1/2#newcode755 Line 755: var max = (proto_length < from) ? proto_length : from; from -> to This code does not seem to be exercised by a test. Please make sure to add testing of all the cases here. This is rather subtle. http://codereview.chromium.org/99272/diff/1/2#newcode794 Line 794: if (!is_array & num_non_undefined + 1 < max_prototype_element) { & -> && Also, could you put in some parenthesis to clearify. http://codereview.chromium.org/99272 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
