Does it lint? LGTM.
http://codereview.chromium.org/99272/diff/1007/9 File src/array.js (right): http://codereview.chromium.org/99272/diff/1007/9#newcode717 Line 717: for (var o = obj.__proto__; o; o = o.__proto__) { Can't we call o proto or something? These 1-letter variable names make things hard to read. http://codereview.chromium.org/99272/diff/1007/9#newcode721 Line 721: // It's an interval Missing full stop. http://codereview.chromium.org/99272/diff/1007/9#newcode748 Line 748: for (var o = obj.__proto__; o; o = o.__proto__) { And here. http://codereview.chromium.org/99272/diff/1007/9#newcode752 Line 752: // It's an interval And here. http://codereview.chromium.org/99272/diff/1007/9#newcode754 Line 754: if (proto_length > from) { > = perhaps? http://codereview.chromium.org/99272/diff/1007/9#newcode787 Line 787: var max_prototype_element = CopyFromPrototype(this, length); I think the var declaration should be hoisted out of the {} if you are going to use it outside the {}. I know JS doesn't care, but I do! http://codereview.chromium.org/99272 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
