LGTM wih comments. -Ivan
http://codereview.chromium.org/108002/diff/1/3 File src/mark-compact.cc (right): http://codereview.chromium.org/108002/diff/1/3#newcode570 Line 570: if (!(*p)->IsHeapObject()) continue; Can there be non-heap entries in the symbol table? I guess the table is initialized to zeroes, but it would be nice to comment it here, so that I and others don't have to figure that out everytime we read this code. http://codereview.chromium.org/108002/diff/1/2 File src/mark-compact.h (right): http://codereview.chromium.org/108002/diff/1/2#newcode178 Line 178: // Mark the symbol table specially. References to symbols are weak. Please clarify: References to symbols from the symbol table are weak. http://codereview.chromium.org/108002 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
