LGTM, but
http://codereview.chromium.org/108002/diff/1/3 File src/mark-compact.cc (right): http://codereview.chromium.org/108002/diff/1/3#newcode572 Line 572: HeapObject* object = HeapObject::cast(*p); The newlines here look weird. How about moving the HeapObject* object definition below the comment? http://codereview.chromium.org/108002/diff/1/3#newcode580 Line 580: object->IterateBody(map->instance_type(), I'd compute the size before the IterateBody call, stuff it in a local variable, and use it to get nicely formatted code where the IterateBody call fits on one line. But that's just me. http://codereview.chromium.org/108002/diff/1/2 File src/mark-compact.h (right): http://codereview.chromium.org/108002/diff/1/2#newcode159 Line 159: UpdateLiveObjectCount(obj, 1); Do you need the scale argument to UpdateLiveObjectCount anymore? http://codereview.chromium.org/108002 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
