Lgtm. A general comment: I've been using the name 'Data' pretty consistently, the same way you do here. However, now I'm thinking that maybe it would be better to call is UserData to make it absolutely clear what it is. Just an idea.
http://codereview.chromium.org/109013/diff/1/3 File include/v8.h (right): http://codereview.chromium.org/109013/diff/1/3#newcode2268 Line 2268: Handle<Value> GetData(); If it returns a local handle consider using the type Local<Value> instead. http://codereview.chromium.org/109013/diff/1/4 File src/api.cc (right): http://codereview.chromium.org/109013/diff/1/4#newcode451 Line 451: { Why the inner scope? http://codereview.chromium.org/109013 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
