As discussed offline changing Data to UserData is th right thing to do. However it should be changed consistently in all places at some point.
http://codereview.chromium.org/109013/diff/1/3 File include/v8.h (right): http://codereview.chromium.org/109013/diff/1/3#newcode2268 Line 2268: Handle<Value> GetData(); On 2009/05/05 09:19:07, Christian Plesner Hansen wrote: > If it returns a local handle consider using the type Local<Value> instead. Done. http://codereview.chromium.org/109013/diff/1/4 File src/api.cc (right): http://codereview.chromium.org/109013/diff/1/4#newcode451 Line 451: { On 2009/05/05 09:19:07, Christian Plesner Hansen wrote: > Why the inner scope? To avoid adding the "env" handle to the outer scope. http://codereview.chromium.org/109013 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
