A few comments with reference to the public Google C++ Style Guide (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml).
When submitting this for readability review remember to note that this is an open source project where all review comments will become public. Also provide some background on things like BASE_EMBEDDED and the TEST macro. http://codereview.chromium.org/115024/diff/1001/16 File src/func-name-inferrer.h (right): http://codereview.chromium.org/115024/diff/1001/16#newcode45 Line 45: FuncNameInferrer() : : on the next line (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Initializer_Lists#Initializer_Lists) http://codereview.chromium.org/115024/diff/1001/16#newcode52 Line 52: bool IsOpen() const { return !entries_stack_.is_empty(); } All function declarations should have a comment (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Comments#Function_Comments) http://codereview.chromium.org/115024/diff/1001/16#newcode102 Line 102: explicit ScopedFuncNameInferrer(FuncNameInferrer* inferrer) : : on the next line (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Initializer_Lists#Initializer_Lists) http://codereview.chromium.org/115024/diff/1001/17 File src/log.cc (right): http://codereview.chromium.org/115024/diff/1001/17#newcode304 Line 304: // See description in v8.h. v8.h -> include/v8.h as v8.h is ambiguous. http://codereview.chromium.org/115024/diff/1001/17#newcode310 Line 310: private: Blank line before private: (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Class_Format#Class_Format) http://codereview.chromium.org/115024 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
