Thank you very much!
http://codereview.chromium.org/115024/diff/1001/16 File src/func-name-inferrer.h (right): http://codereview.chromium.org/115024/diff/1001/16#newcode45 Line 45: FuncNameInferrer() : On 2009/05/06 16:10:35, Søren Gjesse wrote: > : on the next line (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Initializer_Lists#Initializer_Lists) Done. http://codereview.chromium.org/115024/diff/1001/16#newcode52 Line 52: bool IsOpen() const { return !entries_stack_.is_empty(); } On 2009/05/06 16:10:35, Søren Gjesse wrote: > All function declarations should have a comment (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Comments#Function_Comments) Done. http://codereview.chromium.org/115024/diff/1001/16#newcode102 Line 102: explicit ScopedFuncNameInferrer(FuncNameInferrer* inferrer) : On 2009/05/06 16:10:35, Søren Gjesse wrote: > : on the next line (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Initializer_Lists#Initializer_Lists) Done. http://codereview.chromium.org/115024/diff/1001/17 File src/log.cc (right): http://codereview.chromium.org/115024/diff/1001/17#newcode304 Line 304: // See description in v8.h. On 2009/05/06 16:10:35, Søren Gjesse wrote: > v8.h -> include/v8.h as v8.h is ambiguous. Done. http://codereview.chromium.org/115024/diff/1001/17#newcode310 Line 310: private: On 2009/05/06 16:10:35, Søren Gjesse wrote: > Blank line before private: (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Class_Format#Class_Format) Done. http://codereview.chromium.org/115024 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
