I don't know much about how our tick stuff works, but I imagine all of the other tools need changes to (tick processor, etc).
http://codereview.chromium.org/113094/diff/1/2 File src/log.cc (right): http://codereview.chromium.org/113094/diff/1/2#newcode1085 Line 1085: msg.Append("tick,0x%p,0x%p,%d", sample->pc, sample->sp, I realize this is our own StringStream, but just FYI that %p is different between Windows and Linux. http://codereview.chromium.org/113094/diff/1/2#newcode1091 Line 1091: msg.Append(",0x%p", reinterpret_cast<uint32_t>(sample->stack[i])); why are you usin %p for a non-pointer? http://codereview.chromium.org/113094/diff/1/4 File src/platform-win32.cc (right): http://codereview.chromium.org/113094/diff/1/4#newcode1778 Line 1778: #if V8_HOST_ARCH_64_BIT shouldn't we check for X64 here. http://codereview.chromium.org/113094 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
