I added macro for our the pointer format om the other changelist. I'll use it here instead of %p as well.
http://codereview.chromium.org/113094/diff/1/2 File src/log.cc (right): http://codereview.chromium.org/113094/diff/1/2#newcode1085 Line 1085: msg.Append("tick,0x%p,0x%p,%d", sample->pc, sample->sp, Yes, it needs to be changed. Will do that in another changelist and use the change here as well. http://codereview.chromium.org/113094/diff/1/2#newcode1091 Line 1091: msg.Append(",0x%p", reinterpret_cast<uint32_t>(sample->stack[i])); Because I forgot to remove the cast. Good catch. http://codereview.chromium.org/113094/diff/1/4 File src/platform-win32.cc (right): http://codereview.chromium.org/113094/diff/1/4#newcode1778 Line 1778: #if V8_HOST_ARCH_64_BIT No, this is really the host system's registers, not the target system's (potentially simulated) ones. http://codereview.chromium.org/113094 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
