LGTM
http://codereview.chromium.org/113095/diff/1001/1002 File src/heap.cc (right): http://codereview.chromium.org/113095/diff/1001/1002#newcode559 Line 559: static void VerifyNonPointerSpacePointers() { If you move the flag test into this you and put an empty implementation in an #else you can get rid of an intra-function ifdef at the cost of adding an extra-function #else. That seems like a clear style win to me. http://codereview.chromium.org/113095 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
