Thanks for finding a minute of your holiday time on a review!
http://codereview.chromium.org/115123/diff/1/2 File src/log.cc (right): http://codereview.chromium.org/115123/diff/1/2#newcode426 Line 426: if (Write != WriteToMemory) return 0; On 2009/05/08 09:59:33, Søren Gjesse wrote: > Maybe we should consider having an enum to indicate to where log output is going > instead of checking the write function. And end up have two variables for specifying mode (Write and the new enum)? No. I think the current semantics is fine. http://codereview.chromium.org/115123 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
