LGTM

http://codereview.chromium.org/115123/diff/1/2
File src/log.cc (right):

http://codereview.chromium.org/115123/diff/1/2#newcode426
Line 426: if (Write != WriteToMemory) return 0;
Maybe we should consider having an enum to indicate to where log output
is going instead of checking the write function.

http://codereview.chromium.org/115123

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to