LGTM, if the test crashes before the fix and not after. You may want to consider a Handle<JSObject>::cast(proto) in runtime.cc:HasLocalPropertyImplementation instead of the JSObject::cast(*proto).
On Fri, May 8, 2009 at 12:33 AM, <[email protected]> wrote: > Reviewers: Kasper Lund, > > Description: > Fix intermittent crashes caused by unexpected GCs in > HasLocalProperty (bug introduced in r1882 et al.) > > Please review this at http://codereview.chromium.org/115106 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/objects.h > M src/objects.cc > M src/runtime.cc > M test/cctest/test-api.cc > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
