2009/5/8 Kasper Lund <[email protected]>: > LGTM, if the test crashes before the fix and not after.
Before the fix the test crashed every time in debug mode. In release mode the test made the Threading test (of which it is also a part) crash around half the time. I couldn't get it to crash every time. With the fix of course it doesn't crash. > You may want > to consider a Handle<JSObject>::cast(proto) in > runtime.cc:HasLocalPropertyImplementation instead of the > JSObject::cast(*proto). Done. > > On Fri, May 8, 2009 at 12:33 AM, <[email protected]> wrote: >> Reviewers: Kasper Lund, >> >> Description: >> Fix intermittent crashes caused by unexpected GCs in >> HasLocalProperty (bug introduced in r1882 et al.) >> >> Please review this at http://codereview.chromium.org/115106 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M src/objects.h >> M src/objects.cc >> M src/runtime.cc >> M test/cctest/test-api.cc >> >> >> > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
