LGTM Thank you for cleaning this up - it looks much better now.
http://codereview.chromium.org/113399/diff/34/49 File src/debug-delay.js (right): http://codereview.chromium.org/113399/diff/34/49#newcode1808 Line 1808: * @return {Object} JSON formatted object value Returns object - not JSON formatted. http://codereview.chromium.org/113399/diff/34/49#newcode1810 Line 1810: function SimpleObjectToJSON_(object, mirror_serializer) { I think this function should not have JSON in it's name as it does not return JSON but an object. How about SimpleObjectToProtocolObject? http://codereview.chromium.org/113399/diff/34/49#newcode1835 Line 1835: * @return {Array} JSON formatted array value Returns array - not JSON formatted. http://codereview.chromium.org/113399/diff/34/49#newcode1837 Line 1837: function SimpleArrayToJSON_(array, mirror_serializer) { No JSON in name (as above). http://codereview.chromium.org/113399/diff/34/49#newcode1852 Line 1852: * @return {*} JSON formatted value Return value is not JSON formatted. http://codereview.chromium.org/113399/diff/34/49#newcode1854 Line 1854: function SimpleValueToJSON_(value, mirror_serializer) { No JSON in name (as above). http://codereview.chromium.org/113399/diff/34/48 File src/mirror-delay.js (right): http://codereview.chromium.org/113399/diff/34/48#newcode1734 Line 1734: */ Return value is an object. http://codereview.chromium.org/113399/diff/34/48#newcode1962 Line 1962: * @returns {String} JSON serialization Return value is not string. http://codereview.chromium.org/113399/diff/34/48#newcode2031 Line 2031: * @returns {String} JSON value Return value is not always a string. http://codereview.chromium.org/113399 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
