LGTM, but I'd like to get Bill's feedback too.

http://codereview.chromium.org/113400/diff/1/2
File src/ia32/jump-target-ia32.cc (right):

http://codereview.chromium.org/113400/diff/1/2#newcode225
Line 225:
Too much spacing?

http://codereview.chromium.org/113400/diff/1/3
File src/ia32/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/113400/diff/1/3#newcode194
Line 194: elements_[i].clear_copied();
Can't you add support for coping the is_copied flag directly? All this
clearing, testing, and setting seems complicated.

http://codereview.chromium.org/113400

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to