http://codereview.chromium.org/113400/diff/1/2 File src/ia32/jump-target-ia32.cc (right):
http://codereview.chromium.org/113400/diff/1/2#newcode225 Line 225: On 2009/05/15 06:26:51, Kasper Lund wrote: > Too much spacing? Done. http://codereview.chromium.org/113400/diff/1/2#newcode228 Line 228: reaching_frames_.length() == 1) { Of course. I planned on doing that as another change. http://codereview.chromium.org/113400/diff/1/4 File src/ia32/virtual-frame-ia32.h (right): http://codereview.chromium.org/113400/diff/1/4#newcode118 Line 118: On 2009/05/15 07:45:51, William Hesse wrote: > How about: > // Remove copies and constants from the top mergeable_elements of the frame, > // so that a frame of the same height that differs only on > these elements can be merged to it. > // Use JumpTarget::kAllElements if the entire frame should be made mergeable. Seems misleading. The arbitrary frame could differ anywhere (could have memory where this one has register, or they could have different registers). I'd rather stick to the accurate wording even if it's more verbose. I'll change the "not allowed" so it's clear it's a postcondition and not a precondition. http://codereview.chromium.org/113400 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
