LGTM.
http://codereview.chromium.org/113455/diff/1010/1017 File src/codegen.h (right): http://codereview.chromium.org/113455/diff/1010/1017#newcode99 Line 99: previous = Result::cgen_; Does the static top code generator belong to the Result? I can see it being used elsewhere (JumpTarget). Maybe it fits better in CodeGeneratorScope or CodeGenerator. http://codereview.chromium.org/113455/diff/1010/1014 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/113455/diff/1010/1014#newcode806 Line 806: Result left; A separate cleanup, since we have it now, is to use the top code generator in the deferred code objects. http://codereview.chromium.org/113455/diff/1010/1012 File src/register-allocator.h (right): http://codereview.chromium.org/113455/diff/1010/1012#newcode125 Line 125: explicit Result() { invalidate(); } Doesn't need explicit anymore. http://codereview.chromium.org/113455 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
