http://codereview.chromium.org/113455/diff/1010/1017
File src/codegen.h (right):

http://codereview.chromium.org/113455/diff/1010/1017#newcode99
Line 99: previous = Result::cgen_;
On 2009/05/15 10:50:49, Kevin Millikin wrote:
> Does the static top code generator belong to the Result?  I can see it
being
> used elsewhere (JumpTarget).  Maybe it fits better in
CodeGeneratorScope or
> CodeGenerator.

Good point.  I moved it to the CodeGeneratorScope.  Whenever you need
the current CodeGenerator you can get it as
CodeGeneratorScope::Current().

http://codereview.chromium.org/113455/diff/1010/1012
File src/register-allocator.h (right):

http://codereview.chromium.org/113455/diff/1010/1012#newcode125
Line 125: explicit Result() { invalidate(); }
On 2009/05/15 10:50:49, Kevin Millikin wrote:
> Doesn't need explicit anymore.

Done.

http://codereview.chromium.org/113455

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to