http://codereview.chromium.org/113762/diff/1/2
File src/flag-definitions.h (right):

http://codereview.chromium.org/113762/diff/1/2#newcode340
Line 340: "Log profiling data to memory buffer, memory-saving mode"
On 2009/05/22 11:10:05, William Hesse wrote:
> It is unclear how something that logs to memory can also save memory.
Is it
> reducing the size of the ultimate log file?

Is "lazy" a good name? The intention behind this mode is that profiling
is enabled but doesn't consume resources (mem & cpu) until resumed.

http://codereview.chromium.org/113762/diff/1/6
File test/cctest/test-log.cc (right):

http://codereview.chromium.org/113762/diff/1/6#newcode220
Line 220:
On 2009/05/22 11:10:05, William Hesse wrote:
> Would it be possible to check that ticks are actually logged after
profiling is
> resumed?

Sure. Will add.

http://codereview.chromium.org/113762

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to