A good question indeed. Initially I thought only about Chromium case, so my new flag would be a single big switch that needed to be turned on. But saving resources can also be a virtue outside of Chrome, when logging to a file.
I think, I will remove "memory" from flag name and semantics. On Fri, May 22, 2009 at 16:23, William Hesse <[email protected]> wrote: > How about profiling-suspended. I'm not sure about the connection between > the > memory buffer and the ability to suspend and the starting-suspended. Aren't > these > separate things? > > > On Fri, May 22, 2009 at 1:53 PM, <[email protected]> wrote: >> >> http://codereview.chromium.org/113762/diff/1/2 >> File src/flag-definitions.h (right): >> >> http://codereview.chromium.org/113762/diff/1/2#newcode340 >> Line 340: "Log profiling data to memory buffer, memory-saving mode" >> On 2009/05/22 11:10:05, William Hesse wrote: >>> >>> It is unclear how something that logs to memory can also save memory. >> >> Is it >>> >>> reducing the size of the ultimate log file? >> >> Is "lazy" a good name? The intention behind this mode is that profiling >> is enabled but doesn't consume resources (mem & cpu) until resumed. >> >> http://codereview.chromium.org/113762/diff/1/6 >> File test/cctest/test-log.cc (right): >> >> http://codereview.chromium.org/113762/diff/1/6#newcode220 >> Line 220: >> On 2009/05/22 11:10:05, William Hesse wrote: >>> >>> Would it be possible to check that ticks are actually logged after >> >> profiling is >>> >>> resumed? >> >> Sure. Will add. >> >> http://codereview.chromium.org/113762 > > > > -- > William Hesse > Software Engineer > [email protected] > > Google Denmark ApS > Frederiksborggade 20B, 1 sal > 1360 København K > Denmark > CVR nr. 28 86 69 84 > > If you received this communication by mistake, please don't forward it to > anyone else (it may contain confidential or privileged information), please > erase all copies of it, including all attachments, and please let the sender > know it went to the wrong person. Thanks. > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
