LGTM. We don't want to have an explosion of #ifdef X64 exclusions in the main V8 code, but these seem unavoidable.
http://codereview.chromium.org/115706/diff/1/2 File src/bootstrapper.cc (right): http://codereview.chromium.org/115706/diff/1/2#newcode1536 Line 1536: #ifndef V8_HOST_ARCH_64_BIT This should be marked with a TODO to remove it when the compiler is working. http://codereview.chromium.org/115706/diff/1/7 File test/cctest/test-heap.cc (right): http://codereview.chromium.org/115706/diff/1/7#newcode191 Line 191: ASSERT_EQ(request, OBJECT_SIZE_ALIGN(request)); Shouldn't this be CHECK_EQ? Otherwise, you could have check failures later in release mode, because of a misaligned request. http://codereview.chromium.org/115706 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
