I wonder if we should be stubbing out function calls or function implementations instead (or you could argue that you have stubbed out (part of) an implementation....).
http://codereview.chromium.org/115706/diff/1/2 File src/bootstrapper.cc (right): http://codereview.chromium.org/115706/diff/1/2#newcode1537 Line 1537: if (!InstallNatives()) return; There may be a general documentation advantage to moving the #ifdef (with a TODO) inside Bootstrapper::InstallNatives. It more directly marks that function (rather than this call site) as one that needs to be looked at. The cost is that it probably has to become an #ifndef ... #else ... #endif. http://codereview.chromium.org/115706/diff/1/4 File src/heap.h (right): http://codereview.chromium.org/115706/diff/1/4#newcode1052 Line 1052: ASSERT(Page::IsRSetSet(reinterpret_cast<Address>(current), 0)); Same comment---Page::IsRSetSet could return true in V8_HOST_ARCH_64_BIT. http://codereview.chromium.org/115706 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
