LGTM
http://codereview.chromium.org/113641/diff/1/2 File test/cctest/test-log.cc (right): http://codereview.chromium.org/113641/diff/1/2#newcode166 Line 166: if (next != NULL) return next->Contains(addr); Please add {}'s for one statement if. Maybe use an else part for 'return false'. How long does these chains normally get? If they can get very long consider a loop instead of recursion. http://codereview.chromium.org/113641/diff/1/2#newcode206 Line 206: Address min_addr; Missing trailing underscores? http://codereview.chromium.org/113641/diff/1/2#newcode274 Line 274: Interval bounds; Missing trailing underscores? http://codereview.chromium.org/113641 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
