Thanks, I'll send you a CL fix fixes.
http://codereview.chromium.org/113641/diff/1/2 File test/cctest/test-log.cc (right): http://codereview.chromium.org/113641/diff/1/2#newcode166 Line 166: if (next != NULL) return next->Contains(addr); On 2009/05/25 08:45:53, Søren Gjesse wrote: > Please add {}'s for one statement if. Maybe use an else part for 'return false'. > How long does these chains normally get? If they can get very long consider a > loop instead of recursion. Usually, there is no 'next' at all. 'next' appears only on tests involving snapshots, and there're 2 or 3 items in a chain, so recursion seems to be fine. http://codereview.chromium.org/113641/diff/1/2#newcode206 Line 206: Address min_addr; On 2009/05/25 08:45:53, Søren Gjesse wrote: > Missing trailing underscores? Done. http://codereview.chromium.org/113641/diff/1/2#newcode274 Line 274: Interval bounds; On 2009/05/25 08:45:53, Søren Gjesse wrote: > Missing trailing underscores? Um, actually encapsulation is sort of leaking here, so these members are not private. http://codereview.chromium.org/113641 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
