Reviewers: Kasper Lund,
Message:
Hi Kasper,
I think Mads should review this issue, but he is on I/O. This is a
purely mechanical change done using sed to split "namespace foo {
namespace bar {" declarations in two lines to conform to C++ Style
Guide. Previously I sent a letter to team asking if all are OK with such
change, and no one objected.
Description:
Split nested namespaces declaration in two lines in accordance with C++
Style Guide.
This issue was raised by Brett Wilson while reviewing my changelist for
readability. Craig Silverstein (one of C++ SG maintainers) confirmed
that we should declare one namespace per line. Our way of namespaces
closing seems not violating style guides (there is no clear agreement on
it), so I left it intact.
Please review this at http://codereview.chromium.org/115756
Affected files:
M src/accessors.h
M src/accessors.cc
M src/allocation.h
M src/allocation.cc
M src/arguments.h
M src/arm/assembler-arm-inl.h
M src/arm/assembler-arm.h
M src/arm/assembler-arm.cc
M src/arm/builtins-arm.cc
M src/arm/codegen-arm.h
M src/arm/codegen-arm.cc
M src/arm/constants-arm.h
M src/arm/cpu-arm.cc
M src/arm/debug-arm.cc
M src/arm/disasm-arm.cc
M src/arm/frames-arm.h
M src/arm/frames-arm.cc
M src/arm/ic-arm.cc
M src/arm/jump-target-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/arm/regexp-macro-assembler-arm.h
M src/arm/regexp-macro-assembler-arm.cc
M src/arm/register-allocator-arm.cc
M src/arm/simulator-arm.h
M src/arm/simulator-arm.cc
M src/arm/stub-cache-arm.cc
M src/arm/virtual-frame-arm.h
M src/arm/virtual-frame-arm.cc
M src/assembler.h
M src/assembler.cc
M src/ast.h
M src/ast.cc
M src/bootstrapper.h
M src/bootstrapper.cc
M src/builtins.h
M src/builtins.cc
M src/bytecodes-irregexp.h
M src/char-predicates-inl.h
M src/char-predicates.h
M src/code-stubs.h
M src/code-stubs.cc
M src/code.h
M src/codegen-inl.h
M src/codegen.h
M src/codegen.cc
M src/compilation-cache.h
M src/compilation-cache.cc
M src/compiler.h
M src/compiler.cc
M src/contexts.h
M src/contexts.cc
M src/conversions-inl.h
M src/conversions.h
M src/conversions.cc
M src/counters.h
M src/counters.cc
M src/cpu.h
M src/dateparser-inl.h
M src/dateparser.h
M src/dateparser.cc
M src/debug-agent.h
M src/debug-agent.cc
M src/debug.h
M src/debug.cc
M src/disassembler.h
M src/disassembler.cc
M src/execution.h
M src/execution.cc
M src/factory.h
M src/factory.cc
M src/flags.h
M src/flags.cc
M src/frame-element.h
M src/frames-inl.h
M src/frames.h
M src/frames.cc
M src/func-name-inferrer.h
M src/func-name-inferrer.cc
M src/global-handles.h
M src/global-handles.cc
M src/globals.h
M src/handles-inl.h
M src/handles.h
M src/handles.cc
M src/hashmap.h
M src/hashmap.cc
M src/heap-inl.h
M src/heap.h
M src/heap.cc
M src/ia32/assembler-ia32-inl.h
M src/ia32/assembler-ia32.h
M src/ia32/assembler-ia32.cc
M src/ia32/builtins-ia32.cc
M src/ia32/codegen-ia32.h
M src/ia32/codegen-ia32.cc
M src/ia32/cpu-ia32.cc
M src/ia32/debug-ia32.cc
M src/ia32/frames-ia32.h
M src/ia32/frames-ia32.cc
M src/ia32/ic-ia32.cc
M src/ia32/jump-target-ia32.cc
M src/ia32/macro-assembler-ia32.h
M src/ia32/macro-assembler-ia32.cc
M src/ia32/regexp-macro-assembler-ia32.h
M src/ia32/regexp-macro-assembler-ia32.cc
M src/ia32/register-allocator-ia32.cc
M src/ia32/stub-cache-ia32.cc
M src/ia32/virtual-frame-ia32.h
M src/ia32/virtual-frame-ia32.cc
M src/ic-inl.h
M src/ic.h
M src/ic.cc
M src/interpreter-irregexp.h
M src/interpreter-irregexp.cc
M src/jsregexp-inl.h
M src/jsregexp.h
M src/jsregexp.cc
M src/jump-target-inl.h
M src/jump-target.h
M src/jump-target.cc
M src/list-inl.h
M src/list.h
M src/log.h
M src/log.cc
M src/mark-compact.h
M src/mark-compact.cc
M src/memory.h
M src/messages.h
M src/messages.cc
M src/natives.h
M src/objects-debug.cc
M src/objects-inl.h
M src/objects.h
M src/objects.cc
M src/oprofile-agent.h
M src/oprofile-agent.cc
M src/parser.h
M src/parser.cc
M src/platform-freebsd.cc
M src/platform-linux.cc
M src/platform-macos.cc
M src/platform-nullos.cc
M src/platform-posix.cc
M src/platform-win32.cc
M src/platform.h
M src/prettyprinter.h
M src/prettyprinter.cc
M src/property.h
M src/property.cc
M src/regexp-macro-assembler-irregexp-inl.h
M src/regexp-macro-assembler-irregexp.h
M src/regexp-macro-assembler-irregexp.cc
M src/regexp-macro-assembler-tracer.h
M src/regexp-macro-assembler-tracer.cc
M src/regexp-macro-assembler.h
M src/regexp-macro-assembler.cc
M src/regexp-stack.h
M src/regexp-stack.cc
M src/register-allocator-inl.h
M src/register-allocator.h
M src/register-allocator.cc
M src/rewriter.h
M src/rewriter.cc
M src/runtime.h
M src/runtime.cc
M src/scanner.h
M src/scanner.cc
M src/scopeinfo.h
M src/scopeinfo.cc
M src/scopes.h
M src/scopes.cc
M src/serialize.h
M src/serialize.cc
M src/shell.h
M src/smart-pointer.h
M src/snapshot-common.cc
M src/snapshot-empty.cc
M src/snapshot.h
M src/spaces-inl.h
M src/spaces.h
M src/spaces.cc
M src/string-stream.h
M src/string-stream.cc
M src/stub-cache.h
M src/stub-cache.cc
M src/token.h
M src/token.cc
M src/top.h
M src/top.cc
M src/usage-analyzer.h
M src/usage-analyzer.cc
M src/utils.h
M src/utils.cc
M src/v8-counters.h
M src/v8-counters.cc
M src/v8.h
M src/v8.cc
M src/v8threads.h
M src/variables.h
M src/variables.cc
M src/version.h
M src/version.cc
M src/virtual-frame.cc
M src/x64/assembler-x64-inl.h
M src/x64/assembler-x64.h
M src/x64/assembler-x64.cc
M src/x64/builtins-x64.cc
M src/x64/codegen-x64.h
M src/x64/codegen-x64.cc
M src/x64/cpu-x64.cc
M src/x64/debug-x64.cc
M src/x64/frames-x64.h
M src/x64/ic-x64.cc
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.cc
M src/x64/virtual-frame-x64.h
M src/zone-inl.h
M src/zone.h
M src/zone.cc
M test/cctest/test-debug.cc
M test/cctest/test-log-ia32.cc
M test/cctest/test-version.cc
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
