I vote we fix the endings too. I'd prefer something like } // namespace v8::internal } // namespace v8
or Mads' suggestion. On Mon, May 25, 2009 at 11:49 AM, <[email protected]> wrote: > LGTM. > > > > http://codereview.chromium.org/115756/diff/1/3 > File src/accessors.h (right): > > http://codereview.chromium.org/115756/diff/1/3#newcode104 > Line 104: } } // namespace v8::internal > Shouldn't we fix this as well or is it usual to have these on the same > line? > > } // namespace internal > } // namespace v8 > > http://codereview.chromium.org/115756 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
