Thanks, Mads!
http://codereview.chromium.org/115756/diff/1/3 File src/accessors.h (right): http://codereview.chromium.org/115756/diff/1/3#newcode104 Line 104: } } // namespace v8::internal On 2009/05/25 09:49:56, Mads Ager wrote: > Shouldn't we fix this as well or is it usual to have these on the same line? > } // namespace internal > } // namespace v8 Craig Silverstein said that there's no agreement on this part yet. I've checked Google's codebase---both 2-line and 1-line styles are used, so our style is OK (at least for now). Personally, I like it more that 2-line style. http://codereview.chromium.org/115756 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
