http://codereview.chromium.org/113767/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/113767/diff/1/3#newcode478
Line 478: // - Function names correspond one-to-one to ia32 instruction
mnemonics.
On 2009/05/25 11:45:04, Kevin Millikin wrote:
> ia32?

Done.

http://codereview.chromium.org/113767/diff/1/3#newcode479
Line 479: // - Unless specified otherwise, instructions operate on 64bit
operands.
On 2009/05/25 11:45:04, Kevin Millikin wrote:
> 64-bit.

Done.

http://codereview.chromium.org/113767/diff/1/3#newcode484
Line 484: // - Naming conflicts with C++ keywords are resolved via a
trailing '_'.
Made more explicit, dashes are removed, agrees with gcc assembler on
suffixes.

http://codereview.chromium.org/113767/diff/1/3#newcode486
Line 486: // NOTE ON INTERFACE: In this interface, we always use a
Register when
On 2009/05/25 11:45:04, Kevin Millikin wrote:
> Do you even need this NOTE?  It sounds like it just says: the IA32
interface was
> ugly and this one is better.

Done.

http://codereview.chromium.org/113767

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to