LGTM.
http://codereview.chromium.org/113767/diff/1/2 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/113767/diff/1/2#newcode37 Line 37: Register rsi = { 7 }; Will we have both eax and rax as registers? We will likely use both, meaningfully, so the code is only really readable if they both exist. They might just be aliases, though, but it would be nice to actually test that you use 32 bit registers with 32 bit opcodes. http://codereview.chromium.org/113767/diff/1/3 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/113767/diff/1/3#newcode553 Line 553: void add(const Operand& dst, const Immediate& x); For completeness, we will need the following combinarions: Register, register Register, Operand Register, Immediate Operand, register Operand, Immediate And we will need them for all four sizes (byte, word, dword, qword). Are there any more cases that I have forgotten? This seems like a lot (on the other hand, we have so far gotten by with only creating the ones we actually use, so it might not be a problem). http://codereview.chromium.org/113767 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
