On 2009/06/03 06:08:11, Søren Gjesse wrote: > Erik, did we ever add a test checking floating point parameter passing when > adding the ARM stack aligment?
> http://codereview.chromium.org/118153/diff/1/3 > File src/platform-linux.cc (right): > http://codereview.chromium.org/118153/diff/1/3#newcode96 > Line 96: return 16; > Currently the ARM code generator depends on this having the value 8. See the > ASSERT in MacroAssembler::EnterExitFrame in src/arm/macro-assembler-arm.cc. Ah, interesting! I had assumed if 8 worked, 16 would work too. > Maybe just adding an #ifdef checking for V8_TARGET_ARCH_ARM and returning 8 in > that case would work for now. Then leave the EABI comment in place as well. I have updated the patch to return 8 on ARM and 16 otherwise. Please check. Thank you! http://codereview.chromium.org/118153 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
