2009/6/3 <[email protected]>: > Erik, did we ever add a test checking floating point parameter passing > when adding the ARM stack aligment?
We already had tests that checked this. All we had to do was run the tests on EABI targets. > > > http://codereview.chromium.org/118153/diff/1/3 > File src/platform-linux.cc (right): > > http://codereview.chromium.org/118153/diff/1/3#newcode96 > Line 96: return 16; > Currently the ARM code generator depends on this having the value 8. See > the ASSERT in MacroAssembler::EnterExitFrame in > src/arm/macro-assembler-arm.cc. Maybe just adding an #ifdef checking for > V8_TARGET_ARCH_ARM and returning 8 in that case would work for now. Then > leave the EABI comment in place as well. > > http://codereview.chromium.org/118153 > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
