LGTM (but I don't completely understand how the compiler works).
http://codereview.chromium.org/141030/diff/1/6 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/141030/diff/1/6#newcode1170 Line 1170: frame_->Push(&value); // Undo the Pop() from above. Would it be faster to inline the remaining three false cases (null, NaN and empty string)? Or is the code for that too big to be inlined? http://codereview.chromium.org/141030 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
