True, I forgot about undetectable, and that Heap numbers can be zero as well.I think you are right that undefined and smis cover the most common uses.
On Mon, Jun 22, 2009 at 10:06 AM, <[email protected]> wrote: > > http://codereview.chromium.org/141030/diff/1/6 > File src/x64/codegen-x64.cc (right): > > http://codereview.chromium.org/141030/diff/1/6#newcode1170 > Line 1170: frame_->Push(&value); // Undo the Pop() from above. > On 2009/06/22 07:47:45, Lasse Reichstein wrote: > >> Would it be faster to inline the remaining three false cases (null, >> > NaN and > >> empty string)? Or is the code for that too big to be inlined? >> > > I count more cases: null, undetectable, empty string, NaN, +0, -0. It > is a lot of code, and I think these cases aren't hit as often. > > > http://codereview.chromium.org/141030 > -- Lasse R.H. Nielsen / [email protected]'Faith without judgement merely degrades the spirit divine' --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
