LGTM

http://codereview.chromium.org/141032/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/141032/diff/1/2#newcode1197
Line 1197: emit_rex_64(dst);
If REX.W isn't required, we might as well use emit_optional_rex_32(dst)

http://codereview.chromium.org/141032/diff/1/2#newcode1223
Line 1223: emit_rex_64(src);
As above.

http://codereview.chromium.org/141032/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/141032/diff/1/3#newcode97
Line 97: int high_bit() const {
We will eventually need this for xmm registers too (mmx registers was a
mistake, and will be removed again).

http://codereview.chromium.org/141032

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to