LGTM
http://codereview.chromium.org/141038/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/141038/diff/1/2#newcode3521 Line 3521: // ------ KeyedLookupCache ------ We do not have separators like this in the rest of the code. Could you remove it (or add in more so it is consistently used)? http://codereview.chromium.org/141038/diff/1/6 File src/heap.h (right): http://codereview.chromium.org/141038/diff/1/6#newcode976 Line 976: inline static void CopyBlock(Object** dst, Object** src, int byte_size); This is not your code, but could you make this 'static inline' to match the rest? http://codereview.chromium.org/141038/diff/1/7 File src/scopeinfo.cc (right): http://codereview.chromium.org/141038/diff/1/7#newcode428 Line 428: Remove extra lines. http://codereview.chromium.org/141038/diff/1/5 File src/scopeinfo.h (right): http://codereview.chromium.org/141038/diff/1/5#newcode168 Line 168: // slot index -1 means the property is absent. Capitalize 'Slot'? http://codereview.chromium.org/141038/diff/1/5#newcode193 Line 193: static void Check(Code* code, Use a more telling name such as 'IsValidEntry'? http://codereview.chromium.org/141038 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
