LGTM.
http://codereview.chromium.org/141040/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/141040/diff/1/4#newcode42 Line 42: #define __ ACCESS_MASM(masm_) At the bottom of this file, beneath CodeGen implementation, there is a section of stubs and deferred code generation, with the correct define of __. If these go there, then __ is defined correctly already. http://codereview.chromium.org/141040/diff/1/2 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/141040/diff/1/2#newcode125 Line 125: #define __ ACCESS_MASM(masm()) Should this go at the top of the file? http://codereview.chromium.org/141040/diff/1/2#newcode139 Line 139: __ pop(rdi); Could pop(rdi) be commented, explaining why it is needed and what it accomplishes? http://codereview.chromium.org/141040 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
