http://codereview.chromium.org/141040/diff/1/2
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/141040/diff/1/2#newcode125
Line 125: #define __ ACCESS_MASM(masm())
On 2009/06/22 10:25:31, William Hesse wrote:
> Should this go at the top of the file?

Done.

http://codereview.chromium.org/141040/diff/10/13
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/141040/diff/10/13#newcode161
Line 161: "  var o = { x: x_value };"
On 2009/06/22 10:31:35, William Hesse wrote:
> Why isn't this hitting the unimplemented
> case ObjectLiteral::Property::COMPUTED:
> in the object from boilerplate code?

It is, accidentally uploaded this instead of just 'var o = { x: 42 }'.
Fixed.

http://codereview.chromium.org/141040

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to