LGTM, with minor comments.
http://codereview.chromium.org/146022/diff/1/2 File src/assembler.h (right): http://codereview.chromium.org/146022/diff/1/2#newcode269 Line 269: #if V8_HOST_ARCH_64_BIT Bill just fixed this, so you should merge with his changes. http://codereview.chromium.org/146022/diff/1/6 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/146022/diff/1/6#newcode2392 Line 2392: __ movq(kScratchRegister, Immediate(value_)); Can't you do the push of the Immediate Smi directly? http://codereview.chromium.org/146022/diff/1/6#newcode2424 Line 2424: __ movq(kScratchRegister, Immediate(value_)); Again, no need to move to scratch register. http://codereview.chromium.org/146022/diff/1/6#newcode2460 Line 2460: __ push(kScratchRegister); Ditto. http://codereview.chromium.org/146022/diff/1/6#newcode2495 Line 2495: //// int int_value = smi_value->value(); ? Remove if unused. http://codereview.chromium.org/146022/diff/1/6#newcode3433 Line 3433: // TODO(X64): Convert number operands to int32 values. Please put in a call to UNIMPLEMENTED. http://codereview.chromium.org/146022/diff/1/8 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/146022/diff/1/8#newcode38 Line 38: #define __ ACCESS_MASM(masm()) Merge error - this looks weird. :-) http://codereview.chromium.org/146022/diff/1/8#newcode152 Line 152: #undef __ Ditto. http://codereview.chromium.org/146022 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
