LGTM.
http://codereview.chromium.org/146022/diff/1/6 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/146022/diff/1/6#newcode2495 Line 2495: //// int int_value = smi_value->value(); On 2009/06/23 09:55:24, Mads Ager wrote: > ? > Remove if unused. The int_value should be used when more operations are implemented - it won't be unused. http://codereview.chromium.org/146022/diff/1/6#newcode3613 Line 3613: __ xor_(rax, rbx); ASSERT(kSmiTag == 0); http://codereview.chromium.org/146022/diff/1/6#newcode3865 Line 3865: __ bind(&call_runtime); Until you think the builtins are compiled and running, I would put an runtime assert here with an error message, and comment it. Otherwise, it may be hard to debug. http://codereview.chromium.org/146022/diff/1/7 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/146022/diff/1/7#newcode564 Line 564: if (!resolved) { This code is very wrong, I think, since InvokeCode no longer leaves the pc_ at 4 bytes past the call address. Replace it with Unimplemented, or fix it. http://codereview.chromium.org/146022 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
