Reviewers: Mikhail Naganov, Message: Misha, thanks a lot for both review and your help offline.
http://codereview.chromium.org/125141/diff/1003/11 File src/log.h (right): http://codereview.chromium.org/125141/diff/1003/11#newcode243 Line 243: inline static bool IsEnabled() { On 2009/06/16 20:01:13, Mikhail Naganov wrote: > I think you can replace calls to Logger::IsEnabled with calls to > Logger::is_enabled, and get rid of this function. I renamed all the methods to is_logging http://codereview.chromium.org/125141/diff/1003/11#newcode261 Line 261: inline static bool is_enabled() { return is_enabled_; } On 2009/06/16 20:01:13, Mikhail Naganov wrote: > A member function defined within the class definition is > taken to be an inline member function, so "inline" is redundant here. Oh yes, thanks http://codereview.chromium.org/125141/diff/1003/11#newcode344 Line 344: // VMState class implementation. A simple stack of VM states held by the On 2009/06/16 20:01:13, Mikhail Naganov wrote: > I suggest to put this implementation into a log-inl.h file, as C++ Style Guide > recommends: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=The_-inl.h_Files#The_-inl.h_Files Thanks a lot, done Description: Attempt to reduce performance penalty for logging and profiling Please review this at http://codereview.chromium.org/125141 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/codegen.cc M src/compiler.cc A src/log-inl.h M src/log.h M src/log.cc M src/platform.h M src/v8.h M tools/gyp/v8.gyp --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
