Please also add 'log-inl.h' into Visual Studio project files
(tools/visual_studio) and into XCode project. I know, this is pain, but
.gyp file is currently only used in Chromium. For a standalone V8,
project files are still used.


http://codereview.chromium.org/125141/diff/3012/3020
File src/log.h (right):

http://codereview.chromium.org/125141/diff/3012/3020#newcode31
Line 31: #include "platform.h"
Is this include really needed? I see you've added a forward declaration
of class Semaphore there, but it already presents in this file.

http://codereview.chromium.org/125141

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to