LGTM
http://codereview.chromium.org/150168/diff/1/3 File src/objects.cc (right): http://codereview.chromium.org/150168/diff/1/3#newcode2312 Line 2312: if (entry != StringDictionary::kNotFound) { NumberDictionary::kNotFound http://codereview.chromium.org/150168/diff/1/8 File src/objects.h (right): http://codereview.chromium.org/150168/diff/1/8#newcode1882 Line 1882: // static bool IsMatch(Key key, Object* other); Short descriptions on each of these four methods would be nice. http://codereview.chromium.org/150168/diff/1/8#newcode2209 Line 2209: // Copies enumerable keys to preallocated fixed array. Add newline before comment. http://codereview.chromium.org/150168/diff/1/8#newcode2236 Line 2236: // Type specific at put (default NONE attributes is used when adding). I would put a newline before the comment. http://codereview.chromium.org/150168/diff/1/8#newcode2241 Line 2241: // Set an existing entry or add a new one if needed. I would put a newline before the comment. http://codereview.chromium.org/150168 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
