First round of comments:
http://codereview.chromium.org/151152/diff/1017/13 File src/heap.cc (right): http://codereview.chromium.org/151152/diff/1017/13#newcode89 Line 89: int Heap::old_generation_size_ = 512*MB; Do you need to change this too? http://codereview.chromium.org/151152/diff/1017/19 File src/serialize.cc (right): http://codereview.chromium.org/151152/diff/1017/19#newcode48 Line 48: // - MAP and OLD spaces: 15 bits of page number, 11 bits of word offset in page This limits the old space size to 256M, right? I wonder if that's okay... http://codereview.chromium.org/151152/diff/1017/18 File src/spaces.cc (right): http://codereview.chromium.org/151152/diff/1017/18#newcode1990 Line 1990: // FixedSizeSpace implementation This is a weird name. The space grows and shrinks. http://codereview.chromium.org/151152/diff/1017/16 File src/spaces.h (right): http://codereview.chromium.org/151152/diff/1017/16#newcode1501 Line 1501: explicit FixedSizeSpace(int max_capacity, AllocationSpace id, Doesn't have to be explicit. http://codereview.chromium.org/151152 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
