Mads, I hope I've addressed all your comments. Tnx a lot for suggestion to simplify logic based on usage: I sent a doc with some stats to you and Kasper.
I hope this CL might be simplified another bit: I think ic.is_contextual (used to determine if we should throw an exception or return failed value) is accessible from stub compiler and thus the whole separation of ForLoad/ForCall trampolines may go away (and stubs become more specialized). Just for my eduation: what does this is_contextual thing means? yours, anton. http://codereview.chromium.org/140069/diff/3001/3002 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/140069/diff/3001/3002#newcode429 Line 429: masm->CheckMaps(holder, eax, GetLastJSObjectProto(holder), On 2009/06/30 09:23:21, Mads Ager wrote: > On 2009/06/30 09:22:28, Mads Ager wrote: > > Can we modify CheckMaps to check to the last JSObject if we pass in > > Heap::undefined_value()? > And by Heap::undefined_value() I of course mean Heap::null_value(). :-) Not directly as holder should be JSObject*, but I use NULL for it, is it fine with you? http://codereview.chromium.org/140069/diff/3001/3003 File src/ic.h (right): http://codereview.chromium.org/140069/diff/3001/3003#newcode38 Line 38: #define IC_UTIL_LIST(ICU) \ On 2009/06/30 09:22:28, Mads Ager wrote: > Align all the '\' at the position for the longest name. Done. http://codereview.chromium.org/140069/diff/3001/3004 File src/stub-cache.cc (right): http://codereview.chromium.org/140069/diff/3001/3004#newcode720 Line 720: * Attempts to load a property with an interceptor (which must present). On 2009/06/30 09:22:28, Mads Ager wrote: > must present -> must be present. Done. http://codereview.chromium.org/140069/diff/3001/3004#newcode792 Line 792: StackFrameIterator it; On 2009/06/30 09:22:28, Mads Ager wrote: > Can we refactor these methods into pairs of methods (one for call and one for > load ICs) that share a couple of helper methods instead? It would be nice to > avoid the need for using a StackFrameIterator to determine if it is a call IC - > we have that information at the call-site. For sure http://codereview.chromium.org/140069 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
