A couple of thinks I forgot: I think I missed the place where you actually use CheckMaps with a NULL holder?
We need tests that cover all cases in the generated code. I would recommend putting in "__ int3();" in one branch at a time and make sure that you have a test that hits that branch. Thanks, -- Mads http://codereview.chromium.org/140069 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
