LGTM
http://codereview.chromium.org/155109/diff/1/4 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/155109/diff/1/4#newcode299 Line 299: #elif // !defined(V8_HOST_ARCH_ARM) I find the comment clearer without the ! here. http://codereview.chromium.org/155109/diff/1/4#newcode305 Line 305: #endif // !defined(V8_HOST_ARCH_ARM) And without the ! here. http://codereview.chromium.org/155109/diff/1/2 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/155109/diff/1/2#newcode1104 Line 1104: Format(instr, "mla'cond's 'rd, 'rm, 'rs, 'rn"); Should be 'rn 'rm 'rs 'rd for similar reasons to the above. http://codereview.chromium.org/155109 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
